Skip to content

fix: send xqueue graders lang, hide_output, and skip_grader - #39396

Merged
feanil merged 1 commit into
openedx:masterfrom
ormsbee:ormsbee/submissions-4.1.2-xblocks-core-2.0.2
Nov 19, 2026
Merged

feanil merged 1 commit into
openedx:masterfrom
ormsbee:ormsbee/submissions-4.1.2-xblocks-core-2.0.2

Conversation

@ormsbee

@ormsbee ormsbee commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Description

Upgrades edx-submissions from 4.1.0 to 4.1.2 and xblocks-core from 2.0.0 to 2.0.2. This fixes openedx/edx-submissions#390.

When the XQueue body was rebuilt from ExternalGraderDetail, every key in a problem's <grader_payload> except grader got dropped. xqueue-watcher's built-in graders also read lang, hide_output, and skip_grader, so:

  • skip_grader problems were graded anyway. Learners could get an error and no credit, or stay on "queued" while the watcher kept retrying.
  • hide_output was ignored, so learners were shown the expected output from the staff answer.
  • lang was ignored. It only affects strings that course teams translate themselves.

What's in these releases:

  • edx-submissions 4.1.1 (fix: send graders grader_payload options and XQueue's submission_time format edx-submissions#391): stores lang, hide_output, and skip_grader on ExternalGraderDetail and puts them back in grader_payload. Also sends submission_time in XQueue's %Y%m%d%H%M%S format and stops sending a hardcoded random_seed. Includes a migration for the new fields. Their defaults give existing rows the same payload they get today.
  • edx-submissions 4.1.2: declares openedx-events as a runtime dependency. The platform already installs it.
  • xblocks-core 2.0.2 (fix: pass grader_payload's lang, hide_output, and skip_grader through xblocks-core#327): reads the three options out of <grader_payload> and passes them to edx-submissions. Also logs a warning instead of failing when <grader_payload> isn't a JSON object, and shows the learner an error instead of leaving them on "queued" forever when send_to_submission fails.

This only affects courses that grade through edx-submissions (the send_to_submission_course.enable waffle flag), not the legacy XQueue HTTP path. Submissions queued before the migration runs will still go out with only grader, since the other keys were never stored.

Why not xblocks-core 3.0.0?

3.0.0 is the latest release, but it removes local CodeJail and unsafe execution, which the platform still uses by default. That upgrade is being done in #39382 along with the settings and test changes it needs. 2.0.2 is the release that has this fix.

Supporting information

Testing instructions

  1. Enable send_to_submission_course.enable for a course that is set up with xqueue-watcher.
  2. Add a code-grading problem whose <grader_payload> is {"grader": "...", "skip_grader": true} and submit an answer.
  3. The grader_payload that the watcher receives should include skip_grader. With 4.1.0/2.0.0 it only had grader.

The lockfile was regenerated with make compile-requirements UV_LOCK_OPTS="--upgrade-package edx-submissions==4.1.2 --upgrade-package xblocks-core==2.0.2", so no other packages change.

🤖 Generated with Claude Code

Upgrades edx-submissions to 4.1.2 and xblocks-core to 2.0.2 so that the
lang, hide_output, and skip_grader keys in a problem's <grader_payload>
reach xqueue-watcher again. They were being dropped when the XQueue body
was rebuilt from ExternalGraderDetail, which only kept "grader". Losing
skip_grader was the worst of it: the watcher would try to grade code the
course never meant to run.

These releases also make submission_time use XQueue's format, stop
sending a hardcoded random_seed, and surface send_to_submission errors to
the learner instead of leaving the submission "queued".

edx-submissions 4.1.1 adds a migration for the new ExternalGraderDetail
fields.

xblocks-core is pinned to 2.0.2 rather than 3.0.0, since 3.0.0 removes
local CodeJail and is being handled in openedx#39382.

See openedx/edx-submissions#390

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ormsbee
ormsbee requested a review from feanil November 18, 2026 17:23
@ormsbee

ormsbee commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

@feanil: I'm not really sure what the plan is for the xblocks-core 3.0 codejail update, so please merge or close this as you see fit.

@feanil
feanil merged commit df7b3b1 into openedx:master Nov 19, 2026
42 checks passed
@ormsbee
ormsbee deleted the ormsbee/submissions-4.1.2-xblocks-core-2.0.2 branch November 19, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In-platform queue forwards only the grader key of <grader_payload>

2 participants